search

palantir / gradle-conjure

Gradle plugin that integrates with the Conjure toolchain
Apache License 2.0
5 stars 21 forks source link

Include versions in all dependencies #1440

Closed pkoenig10 closed 3 months ago

pkoenig10 commented 4 months ago

This ensures that consumer get functioning dependencies when we start relying on new feature of these libraries.

I've just used the latest versions of conjure-java and dialogue, rather than trying to figure out the minimum required version of these dependencies.

We removed support for Retrofit clients in https://github.com/palantir/conjure-java/pull/2135, so that is no longer tested.

pkoenig10 commented 4 months ago

These dependencies are needed by conjure-java so we don't actually know the correct version to recommend here.

Closing in favor of https://github.com/palantir/gradle-conjure/pull/1441.

pkoenig10 commented 4 months ago

Although there is already some coupling here. The gradle-conjure plugin is the thing that adds these dependencies. By the same argument, it can't really know what dependencies are needed, but we accept this separation of responsibility as a necessary limitation. It feels a bit weird for something to recommend dependencies but not a version.

pkoenig10 commented 4 months ago

See https://g.p.b/excavator-checks/excavator-gradle/pull/5064 for more context.

svc-autorelease commented 3 months ago

Released 5.48.0