palantir / gradle-consistent-versions

Compact, constraint-friendly lockfiles for your dependencies
Apache License 2.0
117 stars 14 forks source link

Add WstxInputFactory and WstxOutputFactory to XmlMapper #1245

Closed FinlayRJW closed 1 month ago

FinlayRJW commented 1 month ago

Before this PR

We were not specifying which Input/Output factories to use for our XMLMapper. If not specified, the default mapper is initialised using the class loader here.

When not specified, we might be picking a Stax XMLStreamWriter from another library which can then cause failure

After this PR

==COMMIT_MSG== Add WstxInputFactory and WstxOutputFactory to XmlMapper ==COMMIT_MSG==

Possible downsides?

changelog-app[bot] commented 1 month ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - πŸ› The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [x] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Add WstxInputFactory and WstxOutputFactory to XmlMapper **Check the box to generate changelog(s)** - [x] Generate changelog entry
felixdesouza commented 1 month ago

πŸ‘ approved pending sanity check on problem repo

autorelease3[bot] commented 1 month ago

Released 2.27.0