search

palantir / gradle-docker

a Gradle plugin for orchestrating docker builds and pushes.
Apache License 2.0
748 stars 158 forks source link

Fix typo in the load flag getter/setters #701

Closed shacker27 closed 6 months ago

shacker27 commented 9 months ago

Before this PR

It seems like there was a typo in the getter/setter for the load variable. I noticed this when I was trying to set up buildx multi-architecture publishing and getting errors about having both load and push set, even though I was explicitly setting load to false.

After this PR

==COMMIT_MSG== Fix typo in the load flag getter/setters ==COMMIT_MSG==

Possible downsides?

palantirtech commented 9 months ago

Thanks for your interest in palantir/gradle-docker, @shacker27! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

schlosna commented 9 months ago

Looks good once CLA is signed @shacker27 😃

shacker27 commented 6 months ago

@schlosna just signed today! Thank you!

svc-autorelease commented 6 months ago

Released 0.36.0

schlosna commented 6 months ago

Thanks @shacker27 for the contribution! A release 0.36.0 should be published shortly.