search

palantir / gradle-git-version

a Gradle plugin that uses `git describe` to produce a version string.
Apache License 2.0
378 stars 76 forks source link

Use git-describe to generate version #704

Closed esword closed 1 year ago

esword commented 1 year ago

What happened?

The plugin uses some complex, looping logic to calculate the describe string which forms the basis for the version (See the Git.describe method). This was to support older versions of git (<1.8.4) that did not have all the options that git-describe needed to produce the proper version string directly.

What did you want to happen?

Now that the features have been git-describe for 10+ years and the codebase has shifted to only native git usage, we can replace the custom code with a single call to git describe:

git describe --tags --always --abbrev=7 --first-parent --match=[prefix]* HEAD

ash211 commented 1 year ago

@esword can this issue be closed?

esword commented 1 year ago

Yes

On Mon, Apr 10, 2023 at 6:48 PM Andrew Ash @.***> wrote:

@esword https://github.com/esword can this issue be closed?

— Reply to this email directly, view it on GitHub https://github.com/palantir/gradle-git-version/issues/704#issuecomment-1502432503, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK3PUJ3G3DASUSQ7TXO4LDXASE4NANCNFSM6AAAAAAWK2XFXA . You are receiving this because you were mentioned.Message ID: @.***>