search

palantir / gradle-git-version

a Gradle plugin that uses `git describe` to produce a version string.
Apache License 2.0
383 stars 76 forks source link

Ability to list all tags #817

Open RAtioNAn opened 4 months ago

RAtioNAn commented 4 months ago

Before this PR

For now if there are multiple tags on commit only one of them will be returned when getLastTag() method is invoked. There is no way to query, filter or search for specific tag in case there is more than one.

After this PR

This PR adds new property to get all tags on the commit thus allowing the user to choose one of them for his specific scenario.

==COMMIT_MSG== Adding functionality to list all tags on commit ==COMMIT_MSG==

Possible downsides?

New method added to interface. No code change is required for current users if they do not need this functionality.

palantirtech commented 4 months ago

Thanks for your interest in palantir/gradle-git-version, @RAtioNAn! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

changelog-app[bot] commented 4 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Ability to list all tags **Check the box to generate changelog(s)** - [ ] Generate changelog entry
RAtioNAn commented 2 weeks ago

Hello, Can someone please provide any kind of feedback on this PR?