search

palantir / javapoet

Java library used to generate Java source files.
Apache License 2.0
7 stars 5 forks source link

Mention Maven coordinates in README #54

Closed Marcono1234 closed 1 month ago

Marcono1234 commented 1 month ago

First of all, thanks a lot for forking the JavaPoet project and implementing some of its missing functionality!

In case this fork is intended to be used by the public (and its main purpose is not for Palantir only), it would be useful to mention the Maven coordinates (I assume com.palantir.javapoet:javapoet) in the README. For example with code snippets for Gradle and Maven, and maybe a link to Maven Central and javadoc.io.

Currently it is not obvious that artifacts have already been published, and what their coordinates are.

carterkozak commented 1 month ago

Good idea! Our goal is to maintain this library, since we use poet pretty heavily, but not to make it in any way Palantir-specific. Would you be interested in making that docs PR? Otherwise someone on my end can take a crack at it in the next couple weeks

Marcono1234 commented 1 month ago

Have created #56, I hope it is ok like this.

I wasn't aware though that this requires a CLA...; I won't sign it for this, sorry.

Marcono1234 commented 1 month ago

Our goal is to maintain this library, since we use poet pretty heavily

In that case might be worth commenting on https://github.com/square/javapoet/discussions/866. What do you think?

carterkozak commented 1 month ago

In that case might be worth commenting on https://github.com/square/javapoet/discussions/866. What do you think?

Great idea, done!