palantir / palantir-java-format

A modern, lambda-friendly, 120 character Java formatter.
Apache License 2.0
407 stars 43 forks source link

Avoid computing expensive debug info for all checkState() calls #1029

Closed ash211 closed 4 months ago

ash211 commented 4 months ago

Before this PR

level.representation(State.startingState()) is always calculated, regardless of if the checkState() check fails. This is expensive to compute, so we should avoid doing it unless necessary.

Screenshot 2024-03-13 at 12 33 14 AM

After this PR

==COMMIT_MSG== Avoid computing expensive debug info for all checkState() calls ==COMMIT_MSG==

Possible downsides?

None known

changelog-app[bot] commented 4 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [x] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Avoid computing expensive debug info for all checkState() calls **Check the box to generate changelog(s)** - [x] Generate changelog entry
svc-autorelease commented 4 months ago

Released 2.41.0