search

palantir / palantir-java-format

A modern, lambda-friendly, 120 character Java formatter.
Apache License 2.0
438 stars 46 forks source link

Removing Feature.AD_HOC_FORMATTING from PalantirJavaFormatFormattingService #1083

Closed crogoz closed 5 months ago

crogoz commented 5 months ago

Before this PR

In https://github.com/palantir/palantir-java-format/pull/1078 we switched to the new Formatting APIs following google-java-format's commit: https://github.com/google/google-java-format/commit/84b2c9a2ba382ee7a968518b46afb0d6000ada8d However, this broke the Intelij generation code - see:

new generated code after extracting code: wrong

expected code after extracting code: correct

After this PR

Removing Feature.AD_HOC_FORMATTING from PalantirJavaFormatFormattingService . The flag was remoced from google-java-format as well in a later PR: https://github.com/google/google-java-format/commit/25ce685ffbc1143f3e7d93c8655e8590cfaaf61b

==COMMIT_MSG== Remove AD_HOC_FORMATTING ==COMMIT_MSG==

Possible downsides?

Fixes https://github.com/palantir/palantir-java-format/issues/1080

changelog-app[bot] commented 5 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [x] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Fixes bug where generated code or automated refactoring is formatted incorrectly by removing AD_HOC_FORMATTING **Check the box to generate changelog(s)** - [x] Generate changelog entry
CRogers commented 5 months ago

👍🏻

svc-autorelease commented 5 months ago

Released 2.46.0