palantir / palantir-java-format

A modern, lambda-friendly, 120 character Java formatter.
Apache License 2.0
427 stars 46 forks source link

Stop using the Save Actions plugin (broken in IntelliJ 2023.1) and use native format on save #862

Closed CRogers closed 1 year ago

CRogers commented 1 year ago

Before this PR

We use the Save Actions IntelliJ plugin but it is broken in IntelliJ 2023.1 and is not maintained and will not have a new release.

After this PR

==COMMIT_MSG== Stop using the Save Actions plugin (broken in IntelliJ 2023.1) and use native format on save (requires IntelliJ >=2021.2) ==COMMIT_MSG==

In 2021.2, IntelliJ introduced a new built in reformat on save feature. We configure this instead rather than using a custom plugin.

Possible downsides?

The suggesting of Save Actions lives in baseline unfortunately

changelog-app[bot] commented 1 year ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

Type

- [ ] Feature - [ ] Improvement - [x] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Stop using the Save Actions plugin (broken in IntelliJ 2023.1) and use native format on save (requires IntelliJ >=2021.2) **Check the box to generate changelog(s)** - [x] Generate changelog entry
svc-autorelease commented 1 year ago

Released 2.29.0

ash211 commented 1 year ago

This addresses https://github.com/palantir/gradle-baseline/issues/2545