palantir / palantir-java-format

A modern, lambda-friendly, 120 character Java formatter.
Apache License 2.0
468 stars 48 forks source link

Update IntelliJ compatibility bounds correctly #875

Closed CRogers closed 1 year ago

CRogers commented 1 year ago

Before this PR

In #874, I tried to update the minimum intellij version this is listed to work with. However, it didn't work as the patchPluginXml task changes the plugin.xml file.

After this PR

Use the correct intellij version bound.

==COMMIT_MSG== Update intellij compatibility range in IntelliJ plugin plugin.xml metadata file, but hopefully correctly this time. ==COMMIT_MSG==

Possible downsides?

changelog-app[bot] commented 1 year ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

Type

- [ ] Feature - [ ] Improvement - [x] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Update intellij compatibility range in IntelliJ plugin `plugin.xml` metadata file, but hopefully correctly this time. **Check the box to generate changelog(s)** - [x] Generate changelog entry
CRogers commented 1 year ago

I ran ./gradlew buildPlugin then checked that the plugin jar contains this in it's plugin.xml:

<idea-version since-build="193" />

by running vim idea-plugin/build/libs/idea-plugin-2.31.0-1-gfdceb49.jar

svc-autorelease commented 1 year ago

Released 2.32.0