search

palantir / palantir-java-format

A modern, lambda-friendly, 120 character Java formatter.
Apache License 2.0
468 stars 48 forks source link

Fix NoSuchMethodError happening on JDK 21 (fixes #885) #886

Closed gnodet closed 1 year ago

gnodet commented 1 year ago

See #885 for the full description of this issue. The PR simply changed the argument to the interface so that the return type is not changed across JDKs.

palantirtech commented 1 year ago

Thanks for your interest in palantir/palantir-java-format, @gnodet! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

fawind commented 1 year ago

Will take a look at getting the "Validation" action running on forks

svc-autorelease commented 1 year ago

Released 2.33.0

basil commented 1 year ago

Did not fix the problem for me: https://github.com/palantir/palantir-java-format/issues/885#issuecomment-1661028726

gnodet commented 1 year ago

Did not fix the problem for me: #885 (comment)

Unfortunately, I have to agree here...