search

palantir / palantir-java-format

A modern, lambda-friendly, 120 character Java formatter.
Apache License 2.0
426 stars 45 forks source link

Java 21: Pattern Matching + StringTemplate JEP-430 + Unnamed JEP-445 #935

Open npeters opened 11 months ago

npeters commented 11 months ago

Before this PR

May error on parsing Java 21 file.

After this PR

Support of different JEP of Java 21 and preview

Possible downsides?

Build

Code

palantirtech commented 11 months ago

Thanks for your interest in palantir/palantir-java-format, @npeters! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

changelog-app[bot] commented 11 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Java 21: Pattern Matching + StringTemplate JEP-430 + Unnamed JEP-445 **Check the box to generate changelog(s)** - [ ] Generate changelog entry
npeters commented 11 months ago

The build is so painful... I push all the jar / idea-plugin https://github.com/npeters/palantir-java-format/releases/tag/java21-draft.

npeters commented 11 months ago

link to #934 #933 #931

kittech0 commented 10 months ago

great job, now gotta wait for approval

talios commented 10 months ago

Has there been any progress on this PR? Would love to see a new release supporting Java 21.

CRogers commented 10 months ago

Thanks for submitting this PR - although we're unlikely to be able review it/actually support Java 21 in palantir-java-format by the end of the year. There's a significant amount of other work we need to do on our internal repos (currently ongoing) before we can start using Java 21 source features and these take priority. Unfortunately, we are quite resource constrained at the moment.

Until then, you may be able to use something like jitpack (https://jitpack.io/) if it is allowed by your organisation to use this commit hash until we are in a place to review/merging/supporting it.

koppor commented 10 months ago

The build is so painful... I push all the jar / idea-plugin npeters/palantir-java-format@java21-draft (release).

Is there also a chance for the gradle plugin? I also hit some issues and would like to test if the modification works with https://github.com/JabRef/jabref/blob/39569344d4051ac958e4fc5edda89866d0706498/src/main/java/org/jabref/gui/fieldeditors/identifier/IdentifierEditor.java#L63. (which is issue https://github.com/palantir/palantir-java-format/issues/952)

npeters commented 9 months ago

yes, the PR should manage the #952. It is part of 'JEP-441 Pattern Matching switch (with guard)' . There are already a test on the guard: sample is I961.

wb459 commented 6 months ago

@CRogers Is there any news regarding when the team will have the capacity to review this PR?

bmarwell commented 6 months ago

Thanks for submitting this PR - although we're unlikely to be able review it/actually support Java 21 in palantir-java-format by the end of the year.

End of WHICH year? 😄 Jokes aside – can you nominate more maintainers? A few ASF projects like maven use palantir and we would like to have property formatted source code. Maybe one of them could get access to palantir PRs and releases?

talios commented 5 months ago

In relation to this - StringTemplates as we currently no them are 100% dead and will not be in JDK 23, even under --enable-preview: https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html

anbonifacio commented 5 months ago

Maybe a smaller scope would be easier to review? What about limiting the support to the new pattern matching features like case null, defaut ->?

koppor commented 5 months ago

As far as I understand the whole setting, the whole endeavor is blocked by the release of version 2.0 of the IntelliJ Gradle Plugin, because of the fix https://github.com/JetBrains/intellij-platform-gradle-plugin/issues/1494 is needed.

(Source: https://github.com/palantir/palantir-java-format/pull/997)

npeters commented 4 months ago

@koppor How can I assist you? This PR seems too complex to merge and I understand. Perhaps a better approach would be as follows:

  1. Create one pull request with a Gradle configuration build that includes multi-compilation tasks and multi-test task, each targeting a specific JDK version.
  2. Submit another pull request containing the Java code and associated tests

@koppor If you agree with this plan. I can try to do it.

npeters commented 4 months ago

@talios thank you for the point. We need to create a InputAstVisitor class for each java version.

xhyrom commented 4 months ago

How it's looking?

RealYusufIsmail commented 3 months ago

Yo, any updates in regard to the following changes.