[IntelliJ] Add note on Imports

palantir / palantir-java-format

A modern, lambda-friendly, 120 character Java formatter.

Apache License 2.0

469 stars 48 forks source link

Open koppor opened 12 months ago

koppor commented 12 months ago

I have activated palantir java format:

This does not change the code style configured in the IDE:

When executing "optimize imports", the configured style is followed.

[ ] I think, the plugin needs to change the code style to "Default" or - even better - to "palantir" in the IDE settings, to be really transparent, about the import statements

When executing "optimize imports", the palantir-style is followed

General wishes:

[ ] Write down in README.md about the style rules for imports. Maybe a link to the Google Java Style (https://google.github.io/styleguide/javaguide.html#s3.3-import-statements) would be enough?
[ ] Advanced: Supply checkstyle rules to check for palantir's import rules (so that one can use the rules in the CI to check)

jrchen-amzn commented 9 months ago

I'm experiencing similar issues...

I'm curious whether the IntelliJ IDEA plugin could additionally optimize imports while reformatting code now?

okuzan commented 9 months ago

Any updates on this? Would be nice to not only format the code, but imports too, if IDEA supports this itself

yotamshtosselfg commented 6 months ago

This is a nasty one. We turned off Intellij's "auto optimize imports" on-the-fly / on save.

mindhaq commented 4 months ago

We turned off Intellij's "auto optimize imports" on-the-fly / on save.

This is not helping me; first palantir reformats, then the imports are re-ordered, and spotless complains that the formatting is not correct.

koppor commented 4 months ago

This is not helping me; first palantir reformats, then the imports are re-ordered, and spotless complains that the formatting is not correct.

I don't get the comment. On https://github.com/palantir/palantir-java-format/issues/954#issuecomment-2108761245 it is said that "Optimize imports" is off. At your side, it is off, too, but there is still a change by IntelliJ?

@mindhaq Could you double check our "Optimize imports" setting?