changelog-app[bot]
commented
7 months ago Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir
What do the change types mean?
- `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._How are new versions calculated?
- ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.Type
Description
CRogers
svc-autorelease
Fixes https://github.com/palantir/palantir-java-format/issues/979
Before this PR
See linked issue.
I think this is happening because
ProjectRootManager.getInstance(project).getProjectSdk()here is sometimes returningnull. This is allowed by its method contract (there is a@Nullablemarking on the method), so we need to handle it gracefully.After this PR
==COMMIT_MSG== Fix "Could not determine jdk version for project" error ==COMMIT_MSG==
With this PR, I intend for palantir-java-format to handle this situation by logging a warning and not performing any formatting.
Possible downsides?
If this state persists indefinitely, users may find that formatting no longer works and no longer have the warning in their IDE pointing in this direction. Users rarely view IDE warning logs (in fact I had to search for how to find them when researching for this PR).