Nullaway is not enabled, and null handling isn't verified by that plugin.
After this PR
==COMMIT_MSG==
Enable Nullaway
==COMMIT_MSG==
Fix flagged issues by adding @Nullable and handling nulls better with Optional.ofNullable
Possible downsides?
NullAway might fail future PRs more often; it can be fiddly in requirements that tend to be largely unimportant in practice (like that Exception messages can be null).
What do the change types mean?
- `feature`: A new feature of the service.
- `improvement`: An incremental improvement in the functionality or operation of the service.
- `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
- `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
- `deprecation`: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
- `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
- `migration`: A fully automatic upgrade migration task with no engineer input required.
_Note: only one type should be chosen._
How are new versions calculated?
- ❗The `break` and `manual task` changelog types will result in a major release!
- 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
- ✨ All others will result in a minor version release.
Fixes https://github.com/palantir/palantir-java-format/issues/987
Before this PR
Nullaway is not enabled, and null handling isn't verified by that plugin.
After this PR
==COMMIT_MSG== Enable Nullaway ==COMMIT_MSG==
Fix flagged issues by adding
@Nullable
and handling nulls better withOptional.ofNullable
Possible downsides?
NullAway might fail future PRs more often; it can be fiddly in requirements that tend to be largely unimportant in practice (like that Exception messages can be null).