Cleanup Gradle build - Githubissues

palantir / palantir-java-format

A modern, lambda-friendly, 120 character Java formatter.

Apache License 2.0

424 stars 45 forks source link

Cleanup Gradle build #997

Closed shanman190 closed 7 months ago

shanman190 commented 7 months ago

Before this PR

The build was using some old patterns that aren't supported anymore preventing Gradle 8.x adoption.

After this PR

Fixes the current Gradle build at least partially to be compatible with Gradle 8.x
Improves the configuration phase by avoiding creating any tasks or resolving any dependencies
There still remains an issue that can't be resolved as it's upstream in the Intellij plugin which is supposed to be fixed in 2.0 whenever it gets released. https://github.com/JetBrains/gradle-intellij-plugin/issues/1494

Possible downsides?

None.

palantirtech commented 7 months ago

Thanks for your interest in palantir/palantir-java-format, @shanman190! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

koppor commented 4 months ago

@shanman190 Thank you again for the work.

There still remains an issue that can't be resolved as it's upstream in the Intellij plugin which is supposed to be fixed in 2.0 whenever it gets released. DependenciesDownloader eagerly resolves dependencies JetBrains/intellij-platform-gradle-plugin#1494

I see that there is an early version of the 2.0 version of the plugin (https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-dependencies-extension.html). Can this be used in this project somehow?

shanman190 commented 4 months ago

@koppor, it might. If this project is ok with the early access version, then I don't see any harm in trying it out though to prove that it does work.