search

palantir / plottable

:bar_chart: A library of modular chart components built on D3
http://plottablejs.org/
MIT License
2.98k stars 221 forks source link

[Axis.Time] - Restructure to make heavier use on D3 #1839

Open bluong opened 9 years ago

bluong commented 9 years ago

The container instance variables are currently a bunch of D3.Selection arrays, which unless I'm mistaken is pretty anti-conventional of normal D3 code. It also makes it hard to deal with these containers in a D3 manner especially when we have to manipulate them (when needing to add more DOM elements or so).

We should structure them to use the enter/exit style that is conventional of most D3 code

aicioara commented 9 years ago

I will probably consider it in #591 . A lot of the ugly code is there because _setup() axisConfigurations() and weird creation of DOM elements such that we can measure the size of the text in computeLayout()

aicioara commented 9 years ago

For the moment putting it on hold.