[Plot] - Base class does not have a complete implementation

palantir / plottable

:bar_chart: A library of modular chart components built on D3

http://plottablejs.org/

MIT License

2.97k stars 221 forks source link

[Plot] - Base class does not have a complete implementation #2922

Open bluong opened 9 years ago

bluong commented 9 years ago

Possibly due to Plottable.Drawer, if one tries to use Plottable.Plot they would not be able to use it for anything. The plot will also throw an error when attempting to render.

We need to either:

Explore actually having Plottable.Plot be usable since currently it just throws errors on usage.
Declare Plottable.Plot to be an abstract class and then define a contract that subclasses must implement. (This may be API breaking)

jtlan commented 8 years ago

Making Plot abstract could be a little odd, because it extends Component, which is decidedly not abstract (although it doesn't do anything except occupy space). On the flip side, it basically behaves as abstract now because it can't really be used.

jtlan commented 8 years ago

One option is to use a no-op Drawer.