search

palantir / plottable

:bar_chart: A library of modular chart components built on D3
http://plottablejs.org/
MIT License
2.96k stars 224 forks source link

[Plots.Waterfall] Labels not displaying #3042

Open aaronhayes opened 8 years ago

aaronhayes commented 8 years ago

I'm trying to get Labels Displayed on Waterfall Charts but there seems to be a bug - no labels are ever displayed. Following this: http://plottablejs.org/docs/classes/plottable.plots.waterfall.html#labelsenabled

Is there a trick I'm missing?

  var waterfallPlot = new Plottable.Plots.Waterfall()
    .x((d) => d.label, xScale)
    .y((d) => d.value, yScale)
    .total((d) => d.total)
    .labelsEnabled(true)
    .connectorsEnabled(true)
    .addDataset(dataset);
jtlan commented 8 years ago

Thanks for catching this! It looks like Waterfall is not correctly invoking the superclass logic in _additionalPaint().

freedomflyer commented 8 years ago

I think it just hasn't been implemented yet: https://github.com/palantir/plottable/issues/1755