search

palantir / plottable

:bar_chart: A library of modular chart components built on D3
http://plottablejs.org/
MIT License
2.96k stars 224 forks source link

stroke-dasharray support for lineDrawer #3421

Closed waltonseymour closed 6 years ago

waltonseymour commented 6 years ago

This adds support for dashed lines in canvas rendering.

palantirtech commented 6 years ago

Thanks for your interest in palantir/plottable, @waltonseymour! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

themadcreator commented 6 years ago

oh, dang, so fast

themadcreator commented 6 years ago

poke @waltonseymour, just need you to agree to the CLA (https://cla.palantir.com/)

waltonseymour commented 6 years ago

Working on getting that signed and sent over. I'll ping this thread when that's done.

waltonseymour commented 6 years ago

I sent the signed CLA to opensource@palantir.com. Haven't received a response yet. Let me know if you need anything else from my end.

waltonseymour commented 6 years ago

Should be GTG now