Closed waltonseymour closed 6 years ago
Other than my comments, this changes looks good to me. Thanks!
I've updated the PR to address comments.
I've also corrected an issue with tickInterval
where the ticks would be generated with local time while the labels would reflect UTC time.
This PR allows for
Plottable.Formatters.time
to display dates in UTC in addition to local time with the addition of an optional booleanuseUTC
.This flag is also passed down from the
TimeAxis
constructor which also contains the additionaluseUTC
flag.For us, this solves a business requirement of displaying time in UTC without having to modify the underlying Date objects, which has a number of drawbacks.