palantir / plottable

:bar_chart: A library of modular chart components built on D3
http://plottablejs.org/
MIT License
2.97k stars 224 forks source link

Use locked value of bar thickness in more cases. #3445

Closed dcervelli closed 6 years ago

themadcreator commented 6 years ago

There is a subtle issue here. Bar plots don't always have equal-width bars. For example histogram plots have arbitrary start/end coordinates for each bar.

So, there are a couple ways to make sure we're doing this correctly, 1) change _entitiesIntersecting to use super.entitiesInBounds which uses the entityStore's r-tree for ~log(n) intersection lookups, or only use the doLocked invocation when this._fixedBarPixelThickness is true