Closed zerovox closed 6 years ago
When you have a lot of UI elements, this spread (compiled to .push.apply(this._entities, entities)) causes a Maximum Call Stack Exceeded error. Also, .concat is seemingly faster than the .push most of the time: https://jsperf.com/es6-add-element-to-create-new-array-concat-vs-spread-op
.push.apply(this._entities, entities)
.concat
.push
Also, when this exception gets throw, the lock is never released somewhere in StackedBar and at that point your chart is hosed.
When you have a lot of UI elements, this spread (compiled to
.push.apply(this._entities, entities)) causes a Maximum Call Stack Exceeded error. Also,.concatis seemingly faster than the.pushmost of the time: https://jsperf.com/es6-add-element-to-create-new-array-concat-vs-spread-opAlso, when this exception gets throw, the lock is never released somewhere in StackedBar and at that point your chart is hosed.