search

palantir / plottable

:bar_chart: A library of modular chart components built on D3
http://plottablejs.org/
MIT License
2.97k stars 224 forks source link

Add 0x0 size check to canvas #3467

Closed themadcreator closed 6 years ago

themadcreator commented 6 years ago

Prevents error from being thrown when we try to invoke context.drawImage with an argument that is a 0x0 canvas.

Instead we just skip the drawImage.

blueprint-bot commented 6 years ago

Add 0x0 size check to canvas

Demo: quicktests | fiddle

blueprint-bot commented 6 years ago

Test dimensions on all canvases

Demo: quicktests | fiddle

blueprint-bot commented 6 years ago

Reuse variable

Demo: quicktests | fiddle

themadcreator commented 6 years ago

Yeah, i was considering. Might as well

blueprint-bot commented 6 years ago

Add warning for condition that previously threw exception

Demo: quicktests | fiddle