search

palantir / plottable

:bar_chart: A library of modular chart components built on D3
http://plottablejs.org/
MIT License
2.97k stars 223 forks source link

Yarn Build is broken? #3481

Open leemi opened 5 years ago

leemi commented 5 years ago

Bug report

Looks like some sort of typings errors.

Steps to repro:

  1. git clone https://github.com/palantir/plottable.git
  2. yarn install
  3. yarn build

Expected behavior

no errors

Actual behavior

yarn run v1.12.3
$ npm-run-all -p lint:tslint build:tsc -s build:webpack
$ tsc -p .
$ tslint --project tsconfig.json
$ webpack

[at-loader] Using typescript@2.7.2 from typescript and "tsconfig.json" from D:\git\plottable\tsconfig.json.

[at-loader] Using typescript@2.7.2 from typescript and "tsconfig.json" from D:\git\plottable\tsconfig.json.

[at-loader] Checking started in a separate process...

[at-loader] Checking started in a separate process...
Hash: 8c77c15f8fdabfe3e91f82707539afd9d61399b3
Version: webpack 2.2.1
Child
    Hash: 8c77c15f8fdabfe3e91f
    Time: 20021ms
                Asset     Size  Chunks                    Chunk Names
        test/tests.js   3.4 MB       0  [emitted]  [big]  main
    test/tests.js.map  3.95 MB       0  [emitted]         main
       [4] ./test/testMethods.ts 18.7 kB {0} [built]
     [122] ./test/globalInitialization.ts 1.46 kB {0} [built]
     [123] ./test Tests.ts$ 2.92 kB {0} [built]
     [240] ./test/scales/timeScaleTests.ts 17.2 kB {0} [optional] [built]
     [241] ./test/utils/arrayUtilsTests.ts 463 bytes {0} [optional] [built]
     [242] ./test/utils/callbackSetTests.ts 1.4 kB {0} [optional] [built]
     [243] ./test/utils/colorUtilsTests.ts 1.46 kB {0} [optional] [built]
     [244] ./test/utils/domUtilsTests.ts 4.21 kB {0} [optional] [built]
     [245] ./test/utils/mapTests.ts 3.48 kB {0} [optional] [built]
     [246] ./test/utils/mathUtilsTests.ts 12.8 kB {0} [optional] [built]
     [247] ./test/utils/rTreeTests.ts 7.42 kB {0} [optional] [built]
     [248] ./test/utils/setTests.ts 3.69 kB {0} [optional] [built]
     [249] ./test/utils/stackingUtilsTests.ts 8.74 kB {0} [optional] [built]
     [250] ./test/utils/transformAwareTranslatorTests.ts 1.87 kB {0} [optional] [built]
     [309] ./test/index.ts 284 bytes {0} [built]
        + 295 hidden modules

    ERROR in [at-loader] ./src/animators/easingAnimator.ts:159:8 
        TS2551: Property 'attrs' does not exist on type 'Transition<BaseType, any, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/animators/nullAnimator.ts:20:22 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, any, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/axis.ts:243:15 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, D, BaseType, void | {}>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/axis.ts:245:8 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, {}, null, undefined>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/axis.ts:247:8 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, {}, null, undefined>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/axis.ts:249:20 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/axis.ts:406:8 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, D, BaseType, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/axis.ts:415:8 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, D, BaseType, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/axis.ts:432:8 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, D, BaseType, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/axis.ts:435:32 
        TS7006: Parameter 'd' implicitly has an 'any' type.

    ERROR in [at-loader] ./src/axes/axis.ts:435:67 
        TS7006: Parameter 'd' implicitly has an 'any' type.

    ERROR in [at-loader] ./src/axes/axis.ts:436:33 
        TS7006: Parameter 'd' implicitly has an 'any' type.

    ERROR in [at-loader] ./src/axes/axis.ts:436:69 
        TS7006: Parameter 'd' implicitly has an 'any' type.

    ERROR in [at-loader] ./src/axes/axis.ts:444:22 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, D, BaseType, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/axis.ts:445:19 
        TS7006: Parameter 'd' implicitly has an 'any' type.

    ERROR in [at-loader] ./src/axes/axis.ts:452:23 
        TS7006: Parameter 'annotationLabel' implicitly has an 'any' type.

    ERROR in [at-loader] ./src/axes/numericAxis.ts:199:8 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, number, BaseType, void | {}>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/timeAxis.ts:541:15 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, Date, BaseType, void | {}>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/timeAxis.ts:550:37 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, {}, null, undefined>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/timeAxis.ts:551:56 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, {}, null, undefined>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/timeAxis.ts:570:15 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, Date, BaseType, void | {}>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/axes/timeAxis.ts:600:30 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/components/component.ts:265:21 
        TS2551: Property 'styles' does not exist on type 'Selection<HTMLElement, any, any, any>'. Did you mean 'style'?

    ERROR in [at-loader] ./src/components/dragBoxLayer.ts:184:55 
        TS2551: Property 'styles' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'style'?

    ERROR in [at-loader] ./src/components/dragBoxLayer.ts:196:10 
        TS2551: Property 'styles' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'style'?

    ERROR in [at-loader] ./src/components/dragBoxLayer.ts:249:28 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/components/dragBoxLayer.ts:253:28 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/components/dragBoxLayer.ts:257:28 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/components/dragBoxLayer.ts:261:28 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/components/dragBoxLayer.ts:267:33 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/components/dragBoxLayer.ts:268:33 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/components/dragBoxLayer.ts:269:33 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/components/dragBoxLayer.ts:270:33 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/components/dragLineLayer.ts:85:57 
        TS2551: Property 'styles' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'style'?

    ERROR in [at-loader] ./src/components/dragLineLayer.ts:94:25 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/components/guideLineLayer.ts:85:21 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/components/interpolatedColorLegend.ts:307:29 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/components/interpolatedColorLegend.ts:314:14 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, number, BaseType, void | {}>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/components/selectionBoxLayer.ts:139:21 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./src/utils/coerceD3.ts:13:27 
        TS2551: Property 'attrs' does not exist on type 'S'. Did you mean 'attr'?

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:5:1 
        TS2304: Cannot find name 'describe'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:6:3 
        TS2304: Cannot find name 'describe'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:9:5 
        TS2304: Cannot find name 'beforeEach'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:13:5 
        TS2304: Cannot find name 'describe'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:15:7 
        TS2304: Cannot find name 'it'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:21:7 
        TS2304: Cannot find name 'it'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:27:7 
        TS2304: Cannot find name 'it'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:33:7 
        TS2304: Cannot find name 'it'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:39:7 
        TS2304: Cannot find name 'it'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:45:5 
        TS2304: Cannot find name 'describe'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:48:7 
        TS2304: Cannot find name 'it'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:58:7 
        TS2304: Cannot find name 'it'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:68:7 
        TS2304: Cannot find name 'it'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:79:5 
        TS2304: Cannot find name 'describe'.

    ERROR in [at-loader] ./test/animators/easingAnimatorTests.ts:87:7 
        TS2304: Cannot find name 'beforeEach'.

...
...
...

    ERROR in [at-loader] ./test/utils/transformAwareTranslatorTests.ts:23:5 
        TS2304: Cannot find name 'it'.

    ERROR in [at-loader] ./test/utils/transformAwareTranslatorTests.ts:32:41 
        TS2551: Property 'attrs' does not exist on type 'Selection<BaseType, void | {}, any, any>'. Did you mean 'attr'?

    ERROR in [at-loader] ./test/utils/windowUtilsTests.ts:5:1 
        TS2304: Cannot find name 'describe'.

    ERROR in [at-loader] ./test/utils/windowUtilsTests.ts:6:3 
        TS2304: Cannot find name 'it'.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Context

Trying to create some pull requests.

Environment

Windows 10 Yarn 1.12.3 Node 8.9.4

smpeters commented 5 years ago

Transition is a d3 type. There might have been a problem with the @types/d3 that caused these failures. I'm not seeing them with currently released dependencies.