palantir / plottable

:bar_chart: A library of modular chart components built on D3
http://plottablejs.org/
MIT License
2.96k stars 224 forks source link

Reverting dependabot change and fixing test case #3539

Closed Briggsby closed 8 months ago

Briggsby commented 4 years ago

Dependabot's update of webpack-dev-server from 2.11.1 to 3.1.11 cause version mismatches due to its dependencies on later versions of webpacks with breaking changes (such as separating webpack-cli into a separate package). This caused errors when yarn start was run after installation and build. In addition, in a test-case for row wrapping in chart legends the strings were no longer sufficiently long enough to cause row wrapping, causing tests to fail despite legend row wrapping functioning fine. I elongated the strings enough that now the test runs correctly.