search

palantir / plottable

:bar_chart: A library of modular chart components built on D3
http://plottablejs.org/
MIT License
2.96k stars 223 forks source link

Use lodash-es and upgrade to TS@4.4 #3589

Closed michael-yx-wu closed 2 years ago

blueprint-bot commented 2 years ago

Remove weird reference to this

Demo: quicktests | fiddle

michael-yx-wu commented 2 years ago

A lot of casting to SVGRect, DOMRect, ClientRect, etc. because newer definitions for these require us to define things like the x, y, and toJSON properties. Given things were working fine before, I think it's okay to just forcibly cast

blueprint-bot commented 2 years ago

Pick instead of casting and import type

Demo: quicktests | fiddle

blueprint-bot commented 2 years ago

Fix indentation

Demo: quicktests | fiddle

blueprint-bot commented 2 years ago

Remove unnecessary casting

Demo: quicktests | fiddle

blueprint-bot commented 2 years ago

Use lodash-es@4.7.15

Demo: quicktests | fiddle