palantir / plottable

:bar_chart: A library of modular chart components built on D3

http://plottablejs.org/

MIT License

2.97k stars 222 forks source link

Implement smarter stacking logic #800

Closed teamdandelion closed 10 years ago

teamdandelion commented 10 years ago

The stacking logic that will be merged by #789 assumes that stacked data is of the same length, with the same x values, in the same order. If any of these invariants are violated it will misbehave. We should harden this logic (and probably factor it into a util). Also for areaPlots we may want some sort of interpolation behavior.

bluong commented 10 years ago

Currently thinking of using d3's stack layout to handle this.

bluong commented 10 years ago

933 should solve this. Making test to support this assertion should close this issue

jtlan commented 10 years ago

Specifics to StackedBar and ClusteredBar tracking at #1086.

jtlan commented 10 years ago

StackedArea version tracking at #1111.

jtlan commented 10 years ago

Also, need a confirm/deny on the same-order issue for bars. @tkimcoop ?

jtlan commented 10 years ago

Doesn't happen for bars.

For area, we already assume that the data comes in order, so the only issue left is stacking correctly, which is tracked at #1111.