Closed KnisterPeter closed 6 months ago
Thanks for your interest in palantir/policy-bot, @KnisterPeter! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.
@bluekeyes That's indeed much cleaner 😃
It seems to me that this prohibits hosting policy-bot at a non root url, such as my-domain.com/policy-bot/ since my path is getting wiped by the default one. Am i missing something?
@fordneild good point, I think that was an oversight here - the public_url
value should be allowed to contain subpaths and the OAuth routes should be added to those paths. I filed #804 to track this.
Thanks for the quick fix!
This change does use the public_url config value to create the oauth2 callback url. This logic is only setup if the config value has been set.
Closes #724