search

palantir / policy-bot

A GitHub App that enforces approval policies on pull requests
Apache License 2.0
777 stars 108 forks source link

Dedupe Reviewers and TeamReviewers before submitting them to GitHub #856

Closed FraBle closed 1 month ago

FraBle commented 1 month ago

Fixes #855

The code takes the same deduping method as the DetailsReviewers handler.

palantirtech commented 1 month ago

Thanks for your interest in palantir/policy-bot, @FraBle! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

FraBle commented 1 month ago

I signed the CLA

bluekeyes commented 1 month ago

Thanks for the PR. You can test this out using the palantirtechnologies/policy-bot:snapshot image - if it fixes the problem, I can make a new release.

FraBle commented 1 month ago

@bluekeyes Confirmed. The snapshot works fine for us now. 💯

bluekeyes commented 1 month ago

Thanks for verifying, 1.36.1 is out now with the fix

maschwenk commented 1 month ago

@bluekeyes @FraBle thank you! that turnaround time was amazing!