search

palantir / python-jsonrpc-server

A Python 2 and 3 asynchronous JSON RPC server
MIT License
83 stars 36 forks source link

[IMP] use ujson instead of json #24

Closed mpanarin closed 4 years ago

mpanarin commented 4 years ago

as it is faster

https://github.com/dignio/ultrajson https://artem.krylysov.com/blog/2015/09/29/benchmark-python-json-libraries/

gatesn commented 4 years ago

How many pylint diagnostics do you have?! Seems like we might be prematurely optimising here? At the cost of adding a third-party dependency

mpanarin commented 4 years ago

How many pylint diagnostics do you have?! Seems like we might be prematurely optimising here? At the cost of adding a third-party dependency

As I use pylint all the time in my projects - a lot. And this improves the usability of pyls on a huge project by quite a bit. As well as ujson is a common, well-known and stable package.

ccordoba12 commented 4 years ago

@gatesn, we'd like to see this one merged too to have the benefits @mpanarin mentions in Spyder.