search

palantir / python-jsonrpc-server

A Python 2 and 3 asynchronous JSON RPC server
MIT License
83 stars 36 forks source link

Remove future dependency. #32

Closed fabioz closed 4 years ago

fabioz commented 4 years ago

It doesn't seem like there's any use of the future package in this project, so, I think it can be safely removed...

Besides inspecting the source code, I was able to run all the tests locally without it being installed.

Note that the tests still end up installing it due to some of its deps -- one of: versioneer, pylint, pycodestyle or pyflakes end up using it (but I didn't really bother finding out which -- it doesn't seem like those are used either when testing... maybe they can be removed too?)

palantirtech commented 4 years ago

Thanks for your interest in palantir/python-jsonrpc-server, @fabioz! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

delta003 commented 4 years ago

Done in https://github.com/palantir/python-jsonrpc-server/pull/40