test_streams: Compare against string

palantir / python-jsonrpc-server

A Python 2 and 3 asynchronous JSON RPC server

MIT License

83 stars 36 forks source link

test_streams: Compare against string #49

Closed Foxboron closed 3 years ago

Foxboron commented 4 years ago

Unsure why this test wasn't ported to the new format. However the test-suite passes locally on my machine and the Arch package with this patch.

Signed-off-by: Morten Linderud morten@linderud.pw

palantirtech commented 4 years ago

Thanks for your interest in palantir/python-jsonrpc-server, @Foxboron! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

rossbridger commented 3 years ago

We encountered the same issue on downstream: https://github.com/gentoo/gentoo/pull/17882, but it turns out the root cause is that the timestamp this testcase generated is offseted by the timezone settings on user's machine.

Foxboron commented 3 years ago

Ah, unreproducible tests. That is a bit more fun. Any reason why the patch from https://github.com/gentoo/gentoo/pull/17882#issuecomment-709680613 wasn't submitted upstream?