search

palantir / python-language-server

An implementation of the Language Server Protocol for Python
MIT License
2.61k stars 283 forks source link

Allow more references returned in test_references_builtin #778

Closed bnavigator closed 4 years ago

bnavigator commented 4 years ago

Hello,

https://github.com/palantir/python-language-server/blob/0591ade123692cae95ccb15260e6a0390f0620c8/test/plugins/test_references.py#L69-L76

Does len(refs) need to be exactly 1 here? On my system, the test fails because there are quite a few more references found.

goanpeca commented 4 years ago

@dalthviz @andfoy ?

ccordoba12 commented 4 years ago

Does len(refs) need to be exactly 1 here? On my system, the test fails because there are quite a few more references found.

That's a new feature of Jedi 0.16+. I think there's no harm in merging this one.

bnavigator commented 4 years ago

Thank you! Yes it indeed came up while working on #744 / PR dalthviz#1 to #775

dalthviz commented 4 years ago

@ccordoba12 should I merge the proposed changes in dalthviz/python-language-server#1 made by @bnavigator ? (To rerun the CI test suite with the things that @bnavigator worked).

ccordoba12 commented 4 years ago

@dalthviz, I left some comments for @bnavigator in that PR.