palantir / python-language-server

An implementation of the Language Server Protocol for Python
MIT License
2.61k stars 283 forks source link

Add configurable flake8 executable #821

Closed ruhulio closed 4 years ago

ruhulio commented 4 years ago

The context for this change:

Within that context, the flake8_lint plugin tries to start flake8 via a process; either directly or as a module. In both cases, this happens outside of the virtual env so it does not pick up the correct flake8 executable or module.

This change allows for adding an optional explicit executable configuration for flake8 that can point directly to the virtual env's installed version.

This change should be backwards compatible as it defaults to the previous behavior when there is no executable provided in the configuration.

The other plugin's do not have a similar issue as they do not use a separate process.

palantirtech commented 4 years ago

Thanks for your interest in palantir/python-language-server, @ruhulio! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.