search

palantir / python-language-server

An implementation of the Language Server Protocol for Python
MIT License
2.61k stars 283 forks source link

Allow passing explicit environment variables to Jedi environment #822

Closed mrclary closed 4 years ago

mrclary commented 4 years ago

This permits passing explicit environment variables to the jedi environment, which is just passed to subprocess.Popen's env keyword argument. See davidhalter/jedi#1617 and davidhalter/jedi#1619.

palantirtech commented 4 years ago

Thanks for your interest in palantir/python-language-server, @mrclary! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

mrclary commented 4 years ago

@palantirtech Can you take a look at this PR? The only failure is test_exit_with_parent_process_died, which had a TimeoutError, but it seems to pass for me locally.

ccordoba12 commented 4 years ago

Closing and reopening to re-trigger our CIs

ccordoba12 commented 4 years ago

Ok, that didn't work. @mrclary, could you do a git commit --amend and push again to trigger our CIs from your side?

mrclary commented 4 years ago

@ccordoba12, Done. I had to make a correction anyway.

mrclary commented 4 years ago

@ccordoba12, It looks like I missed the 0.35.0 and 0.35.1 releases. Is it possible to get this into the next release?

ccordoba12 commented 4 years ago

I'm testing this as part of spyder-ide/spyder#13839. Once tests pass there, I'll merge this one.