search

palantir / python-language-server

An implementation of the Language Server Protocol for Python
MIT License
2.6k stars 282 forks source link

Parse ignore arguments in flake8 to avoid issues with Atom #824

Closed thodnev closed 4 years ago

thodnev commented 4 years ago

PR addresses #769 as a temporary solution. Basic diagnostic was done here and a quickfix proposed here.

I did not have time to run the tests, hopefully CI will do it for us. Also I don't know all the possible implications, maybe there are some more arguments need to be fixed. I feel like these fixes need to be applied to Atom and its plugins. But, on the other hand having broken Atom used by millions of people is not good for PyLS too. Hope the Atom guys will manage to do their job solving the problem soon.

Fixes #769.

palantirtech commented 4 years ago

Thanks for your interest in palantir/python-language-server, @thodnev! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

thodnev commented 4 years ago

Thanks for your interest in palantir/python-language-server, @thodnev! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Alright, signed it. But guys, I just want you to know. These requirements are inadequate beyond belief. Having the MIT license and CONTRIBUTING is more than enough

ccordoba12 commented 4 years ago

Alright, signed it. But guys, I just want you to know. These requirements are inadequate beyond belief. Having the MIT license and CONTRIBUTING is more than enough

That was determined by the Palantir guys. I'm not affiliated with them in any way, I just help them to maintain this project.

thodnev commented 4 years ago

@ccordoba12 Done. I don't know what are the commit policies of this project. So I've created one more commit with changes instead of rebasing. You could squash merge if two commits is a problem

ccordoba12 commented 4 years ago

Done. I don't know what are the commit policies of this project. So I've created one more commit with changes instead of rebasing.

That's fine. The policy here is to always squash PRs.