search

palantir / python-language-server

An implementation of the Language Server Protocol for Python
MIT License
2.6k stars 282 forks source link

Add code in front of the diagnostic message for flake8 #885

Closed jdhao closed 3 years ago

jdhao commented 3 years ago

For the issue discussed in https://github.com/palantir/python-language-server/issues/884, it would be better to also add the code in front the actual diagnostic message, to make the message style the same as pycodestyle.

Fixes #884.

palantirtech commented 3 years ago

Thanks for your interest in palantir/python-language-server, @jdhao! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

ccordoba12 commented 3 years ago

@jdhao, thanks a lot for this! Probably our tests for the flake8 plugin are failing due to the change you introduced, so you also need to fix them in this PR.

jdhao commented 3 years ago

@jdhao, thanks a lot for this! Probably our tests for the flake8 plugin are failing due to the change you introduced, so you also need to fix them in this PR.

OK, it seems that I also need to update some of the test for flake8 plugin, as the msg format has changed.

jdhao commented 3 years ago

@ccordoba12 I have fixed the bug. Please review it.