search

palantir / python-language-server

An implementation of the Language Server Protocol for Python
MIT License
2.6k stars 282 forks source link

test/plugins/test_folding.py fails: extra range produced #896

Open juliangilbey opened 3 years ago

juliangilbey commented 3 years ago

The test_folding test fails when using Python 3.9 and parso 0.8.1 (though I don't know whether that is the source of the change); inserting a new line:

                {'startLine': 9, 'endLine': 10},

in the expected list allows the test to pass, but I don't know whether this is showing up a bug somewhere.

ccordoba12 commented 3 years ago

This package doesn't support Parso 0.8 nor Jedi 0.18 yet.

juliangilbey commented 3 years ago

Ah, thanks!

juliangilbey commented 3 years ago

On the positive side: https://github.com/ipython/ipython/issues/12740#issuecomment-751273584 Best wishes, Julian

ccordoba12 commented 3 years ago

IPython is not related to this project, sorry.

juliangilbey commented 3 years ago

I was referring to @davidhalter's comment that jedi will soon become stable:

Sorry for that. I did not realize that IPython with that fix was not released yet. I usually test IPython completions before doing a Jedi release, but not this time :/. It will probably also not happen in the future anymore, because I'm going to release Jedi 1.0 soon, so this is probably the last time for a long time that you have to deal with deprecations in Jedi.

Best wishes, Julian