Implement completionItem/resolve

palantir / python-language-server

An implementation of the Language Server Protocol for Python

MIT License

2.61k stars 283 forks source link

Implement completionItem/resolve #905

Closed krassowski closed 3 years ago

krassowski commented 3 years ago

Fixes #903

implemented new hook for resolve
implemented resolve in jedi_completion and rope_completion
added eager option to rope_completion and jedi_completion allow users using clients which cannot yet handle completionItem/resolve to restore to eager resolution (inside of textDocument/completions)
added test for resolve and documentation in Jedi
tested with development version of JupyterLab-LSP client; the client implementation was tested against reference JavaScript/TypeScript server and against the R-languageserver

palantirtech commented 3 years ago

Thanks for your interest in palantir/python-language-server, @krassowski! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

krassowski commented 3 years ago

@ccordoba12 thanks for expressing your interest! The PR is now green and ready for review.

krassowski commented 3 years ago

Cross-referencing my other implementation in https://github.com/pappasam/jedi-language-server/pull/56 which is very similar but some details differ mostly and it might be helpful to compare those during review.

krassowski commented 3 years ago

I believe that the CI failures after last commit are caused by a new release of a dependency used in tests (numpy?) and not by my code. It also explains why only the modern versions (Py3.7 and Py3.8) fail.

andfoy commented 3 years ago

@krassowski, thanks for this PR, right now we lost our permissions on this repo, and we're waiting to see if it is going to be moved to a fork