Implicit dependency on latest Gradle - Githubissues

palantir / sls-packaging

A set of Gradle plugins for creating SLS-compatible packages

Apache License 2.0

38 stars 74 forks source link

Implicit dependency on latest Gradle #687

Open henryptung opened 4 years ago

henryptung commented 4 years ago

What happened?

Excavator updates Gradle wrapper version to latest.
Plugin builds using gradleApi() dependency (both directly declared and implicitly declared via java-gradle-plugin)
Plugin uses APIs that only exist in later Gradle (e.g. Provider.orElse(), since Gradle 5.6)
Plugin fails in older Gradle 5.x projects (e.g. 5.2)

What did you want to happen?

Plugin should conform to version requirements as laid out in release notes (>= 5.1) and should not implicitly bump with every release.

Suggestions

Don't use Excavator to bump Gradle wrapper version
Replace gradleApi() dependency (and java-gradle-plugin) with an explicit dependency on a fixed version of Gradle API

iamdanfox commented 4 years ago

(One more option is to run tests against the specific gradle version we intended to maintain compatibility with)