Drop RedundantModifier to SUGGESTION and FinalClass to WARNING
These checks don't imply bugs, and automation will fix failing cases automatically, so it's not necessary to block compilation. FinalClass moved to warning rather than suggestion because there are a few edge cases (e.g. dependent projects using mockito without inline mock maker) where releases can run into issues if the bots don't fix findings in time.
InvocationHandlers which delegate to another object must catch and unwrap InvocationTargetException, otherwise an UndeclaredThrowableException will be thrown each time the delegate throws an exception.
PreferAssertj disallows assert statements in test code.
Tests should use more specific AssertJ checks, which cannot be disabled by turning off asserts. Arguably the assert keyword should never be used, preferring preconditions. This way production environments cannot reach code paths that are impossible to test.
Adds an ErrorProne rule, JooqResultStreamLeak, which ensures that result streams and cursors returned from jOOQ results are closed in a try-with-resources block.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/latest-baseline-oss check.
Release Notes
2.29.0
StrictCollectionIncompatibleType
to guard collection usageThese checks don't imply bugs, and automation will fix failing cases automatically, so it's not necessary to block compilation.
FinalClass moved to warning rather than suggestion because there are a few edge cases (e.g. dependent projects using mockito without inline mock maker) where releases can run into issues if the bots don't fix findings in time.
2.30.0
InvocationTargetException
, otherwise anUndeclaredThrowableException
will be throwneach time the delegate throws an exception.
2.31.0
2.32.0
assert
statements in test code.Tests should use more specific AssertJ checks, which cannot be disabled by turning off asserts. Arguably the
assert
keyword should never be used, preferring preconditions. This way production environments cannot reach code paths that are impossible to test.2.33.0
Slf4jThrowable
check to ensure throwable args are logged last2.34.0
JooqResultStreamLeak
, which ensures that result streams and cursors returned from jOOQ results are closed in a try-with-resources block.2.35.0
To enable or disable this check, please contact the maintainers of Excavator.