search

palantir / stash-codesearch-plugin

Provides global repository, commit, and file content search for Atlassian Stash instances
Apache License 2.0
62 stars 20 forks source link

Attempting to enable this on Stash 3.3.0, fails on Codesearch search-servlet-global-link #1

Open ultimav opened 9 years ago

ultimav commented 9 years ago

EDIT: Tasks are:

  1. Enable by default
  2. Better surface the error if version of git is too old
  3. Better surface the error if instance of ES is unreachable (and handle reconnecting to it)

Consider breaking 3 out into its own issue maybe.

@ultimav's original issue: I upload the jar, and it does not automatically enable it. I click on enable, and it gives me the same generic error I click a 2nd time, and all modules but Codesearch (search-servlet-global-link) will enable. I think its the web-item.

I only have git 1.7.10.x and i just noticed a 1.8.0.0 requirement.. in my log.. Could this be why? You might want to update the documentation.

I'm still looking for the other error i saw

ultimav commented 9 years ago

Bingo, it was the version of Git.. I enabled 1.9.4 and it installed/enabled correctly

terabyte commented 9 years ago

@ultimav thanks for reporting this - I'm actually going to reopen this issue to track fixing the error messaging because we should surface that error better. Also, I believe changing the defaults to be enabled and better detection of the lack of an ES instance is blocking acceptance to the atlassian marketplace, so we need to do that.