search

palantir / stash-codesearch-plugin

Provides global repository, commit, and file content search for Atlassian Stash instances
Apache License 2.0
62 stars 20 forks source link

Changes #10

Closed gliptak closed 8 years ago

gliptak commented 9 years ago

(Just validated by running JUnit tests at this time)

terabyte commented 9 years ago

Bumping ES version and UTF-8 encoding change look good to me. Supporting the earliest 3.x stash version is also probably fine - at the time I was managing this plugin, I thought compiling against the newest stash would help me find differences, but I have recently learned that the actual production builds should still use the lowest compatible version so that they are recognized as "compatible with that version or newer". Of course, I'm not at Palantir anymore, so the final say is still up to them =)

Many thanks for contributing!

gliptak commented 9 years ago

This works for us in a 3.1.x Stash instance.

terabyte commented 8 years ago

FYI, this has been merged into the master branch of my fork. Thanks!