search

palantir / stash-codesearch-plugin

Provides global repository, commit, and file content search for Atlassian Stash instances
Apache License 2.0
62 stars 20 forks source link

Add support for Bitbucket 4.0.0 #16

Open mithun opened 8 years ago

mithun commented 8 years ago

This PR adds support for Bitbucket Server 4.0.0

Various changes from @terabyte and @gliptak are also merged in.

mithun commented 8 years ago

Actually. Scratch that. It only compiles, but doesn't work yet. The soy templates are not rendering. Can someone help fix that? (I have no experience with Atlassian plugin development)

terabyte commented 8 years ago

I (no longer at palantir) will see what I can do if I get a chance. Typically Palantir doesn't do major version bumps of atlassian stuff until they are on X.1 or X.2, so it could take them a while to get to it.

terabyte commented 8 years ago

@mithun @gliptak Thanks very much for your changes so far - I am testing every change before the bitbucket change in a separate branch which I will push to terabyte/stash-code-search master once I am satisfied. Then I'll take a look at the bitbucket changes and see what I can do there.

mithun commented 8 years ago

@terabyte Sounds good. Thanks.

terabyte commented 8 years ago

Ok, everything is in except for the bitbucket 4.0.0 commit. I am taking a look now.

gliptak commented 8 years ago

Will https://github.com/terabyte/stash-codesearch-plugin become the new official repo? @terabyte Are you planning to publish to Atlassian plugin repo (preferably both 3.x and 4.x versions)? Thanks

terabyte commented 8 years ago

I don't know the answer to those questions yet. If Palantir is willing to support this thing and keep it up to date I see no reason to fork, but if there isn't resources to do that, better that someone does it.

Thanks to the wonder of DVCS, it suffices to say right now that there is no "official" repo, just the palantir version and the terabyte version. Whether or not I upload my versions to the marketplace will again depend upon palantir's willingness to do so. I worry if I go full hog and fork needlessly I'm potentially just making more work for myself, because they could ask me to change the plugin key and logos (maybe? unsure about the legalities there).

terabyte commented 8 years ago

Almost have it working, but not quite: https://github.com/terabyte/stash-codesearch-plugin/tree/feature/bitbucket-4.0

The search works, but the servlets aren't rendering quite right yet.

mithun commented 8 years ago

@terabyte I just tried https://github.com/terabyte/stash-codesearch-plugin/releases/tag/2.0.0 and it works for me. Thanks for helping out.

terabyte commented 8 years ago

awesome! no problemo, glad to help out!