search

palantir / tenablesc-client

A Golang-based API client for Tenable.SC
Other
9 stars 8 forks source link

Accept/recast rules can't converge on non-any protocol #15

Closed rickatnight11 closed 2 years ago

rickatnight11 commented 2 years ago

What happened?

The Tenable.sc recast/accept APIs require setting protocol to either any or an integer for the protocol number, however the APIs return the cosmetic name for the protocol. This means that setting the protocol to anything other than any results in Terraform never converging:

Example:

  # module.vuln_recast_70658.tenablesc_recast_risk.this["7"] will be updated in-place
  ~ resource "tenablesc_recast_risk" "this" {
        id            = "21"
      ~ protocol      = "TCP" -> "6"
        # (6 unchanged attributes hidden)
    }

This adds a bunch of noise to every run, because functionally the value is already correct.

What did you want to happen?

The rules should apply and not show changes in subsequent runs. I think this can be fixed by applying a protocol number/name lookup either at write or read time.

dreamlibrarian commented 2 years ago

Moved to https://github.com/palantir/terraform-provider-tenablesc/issues/27

I think github's being spicy, given I tried opening against the provider and ended up with a dupe over here.