palantir / tenablesc-client

A Golang-based API client for Tenable.SC
Other
9 stars 8 forks source link

Updates to allow retrieving reports and base report definitions #28

Closed jamesshank closed 1 year ago

jamesshank commented 1 year ago

Before this PR

I need to pull Reports and Report Definitions to support needs.

After this PR

We can now pull Reports and Report Definitions.

Possible downsides?

Nope

changelog-app[bot] commented 1 year ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

Type

- [ ] Feature - [ ] Improvement - [ ] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Updates to allow retrieving reports and base report definitions **Check the box to generate changelog(s)** - [ ] Generate changelog entry
akarnani commented 1 year ago

Hey @jamesshank,

Thanks for another contribution! I had a few comments/questions on type choices for the new struct but otherwise looks great to me.

jamesshank commented 1 year ago

Thanks for the comments, @akarnani! I've addressed them all, nice catch.

All the best!

akarnani commented 1 year ago

Thanks for the updates. It looks like uuid is a core attribute of a User so perhaps we should lift it into UserInfo?

jamesshank commented 1 year ago

Thanks for the updates. It looks like uuid is a core attribute of a User so perhaps we should lift it into UserInfo?

Per here I'm not seeing UUID, only ID. Can you advise?

jamesshank commented 1 year ago

Thanks for the updates. It looks like uuid is a core attribute of a User so perhaps we should lift it into UserInfo?

Per here I'm not seeing UUID, only ID. Can you advise?

Yep, I understand now. Forgive me. Just a sec addressing now.

jamesshank commented 1 year ago

@akarnani Feel free to take a look when you can! I think we should be good now.

Thanks!

akarnani commented 1 year ago

Thanks again @jamesshank, LGTM.

svc-autorelease commented 1 year ago

Released 0.7.0