Closed jamesshank closed 1 year ago
Type
Description
Hey @jamesshank,
Thanks for another contribution! I had a few comments/questions on type choices for the new struct but otherwise looks great to me.
Thanks for the comments, @akarnani! I've addressed them all, nice catch.
All the best!
Thanks for the updates. It looks like uuid
is a core attribute of a User
so perhaps we should lift it into UserInfo
?
Thanks for the updates. It looks like
uuid
is a core attribute of aUser
so perhaps we should lift it intoUserInfo
?
Per here I'm not seeing UUID, only ID. Can you advise?
Thanks for the updates. It looks like
uuid
is a core attribute of aUser
so perhaps we should lift it intoUserInfo
?Per here I'm not seeing UUID, only ID. Can you advise?
Yep, I understand now. Forgive me. Just a sec addressing now.
@akarnani Feel free to take a look when you can! I think we should be good now.
Thanks!
Thanks again @jamesshank, LGTM.
Released 0.7.0
Before this PR
I need to pull Reports and Report Definitions to support needs.
After this PR
We can now pull Reports and Report Definitions.
Possible downsides?
Nope