search

palantir / terraform-provider-tenablesc

Terraform provider for managing Tenable.SC configuration
Other
7 stars 4 forks source link

Add optional attribute `Inactivity timeout` for tenablesc_scan resource #168

Closed arminaaki closed 3 months ago

arminaaki commented 3 months ago

Before this PR

The recent upgrade in Tenable.sc introduced API changes, setting certain defaults that disrupt the creating new scans.

Error seen:

│ Error: failed to create scan: Please modify Inactivity Timeout. It cannot be more than Max Scan Duration.
│ The attribute 'inactivityTimeout' contains the value '43200' which should be an integer from 3600 to 3600.

After this PR

The change should allow creating new scans via Terraform.

Possible downsides?

None

changelog-app[bot] commented 3 months ago

Generate changelog in changelog-dir>`changelog/@unreleased`</changelog-dir

What do the change types mean? - `feature`: A new feature of the service. - `improvement`: An incremental improvement in the functionality or operation of the service. - `fix`: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way. - `break`: Has the potential to break consumers of this service's API, inclusive of both Palantir services and external consumers of the service's API (e.g. customer-written software or integrations). - `deprecation`: Advertises the intention to remove service functionality without any change to the operation of the service itself. - `manualTask`: Requires the possibility of manual intervention (running a script, eyeballing configuration, performing database surgery, ...) at the time of upgrade for it to succeed. - `migration`: A fully automatic upgrade migration task with no engineer input required. _Note: only one type should be chosen._
How are new versions calculated? - ❗The `break` and `manual task` changelog types will result in a major release! - 🐛 The `fix` changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease. - ✨ All others will result in a minor version release.

Type

- [ ] Feature - [ ] Improvement - [x] Fix - [ ] Break - [ ] Deprecation - [ ] Manual task - [ ] Migration

Description

Add optional attribute `Inactivity timeout` for tenablesc_scan resource **Check the box to generate changelog(s)** - [x] Generate changelog entry
akerl commented 3 months ago

👍