search

palantir / tslint-react

:orange_book: Lint rules related to React & JSX for TSLint.
Apache License 2.0
749 stars 76 forks source link

Support JSX Fragment syntax for jsx-wrap-multiline. #130

Closed dmiller9911 closed 6 years ago

dmiller9911 commented 6 years ago

Fixes #124

Added a check for ts.syntaxKind.JsxFragment in jsx-wrap-multiline. A newer version of tsutils has this check as well, but I was unsure of the policy for updating dependencies. If you would rather upgrade I will do that instead.

Add tests to verify positive and negative cases. Upgrade ts devDependency to 2.6.2.

palantirtech commented 6 years ago

Thanks for your interest in palantir/tslint-react, @dmiller9911! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

adidahiya commented 6 years ago

A newer version of tsutils has this check as well, but I was unsure of the policy for updating dependencies. If you would rather upgrade I will do that instead.

Yes please, feel free to upgrade tsutils

dmiller9911 commented 6 years ago

Will wait for https://github.com/ajafff/tsutils/pull/17 before updating tsutils.

adidahiya commented 6 years ago

@dmiller9911 can you please pull in master to get the new CI setup and required checks? Also enable CI on your branch if you haven't yet.