palantir / tslint-react

:orange_book: Lint rules related to React & JSX for TSLint.
Apache License 2.0
749 stars 76 forks source link

Pull in rules from tslint-microsoft-contrib #202

Closed JoshuaKGoldberg closed 5 years ago

JoshuaKGoldberg commented 5 years ago

tslint-microsoft-contrib has several React-related rules, particularly around accessibility, that really belong in this repository:

Would you accept PRs to move them here? Are there preferences around this?

adidahiya commented 5 years ago

Is there a downside to leaving them where they are now?

edit: is it primarily about discoverability? I don't think moving them here for the purpose of giving them more "authority" would help, as this repo hasn't been maintained well over the past 6 months

JoshuaKGoldberg commented 5 years ago

I believe it's been a point of confusion for users that there are two popular contributed rulesets with React-specific rules. Prior to the TSLint deprecation plans and this repository being somewhat unmaintained, it would have been nice to better delineate which rules go where.

At this point, I'm ok with taking no action.

adidahiya commented 5 years ago

Closing due to deprecation timeline, see #210